Skip to content

More logic #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 13, 2025
Merged

More logic #1387

merged 34 commits into from
Aug 13, 2025

Conversation

fredrik-bakke
Copy link
Collaborator

Pulls logic additions from #1264.

Copy link
Collaborator

@VojtechStep VojtechStep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to go through the first half of files, hopefully to be continued some time next week

Copy link
Collaborator

@VojtechStep VojtechStep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the extra late review. I have some naming questions around density and propositional decidability I would like to have addressed before merging this development.

fredrik-bakke and others added 13 commits June 6, 2025 11:03
…da.md

Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
@fredrik-bakke
Copy link
Collaborator Author

@VojtechStep Thank you for the detailed review! I've tried to address all of your comments now. Let me know if further changes are required.

@VojtechStep
Copy link
Collaborator

I might not have the time today, but I should be able to look at all the updated PRs tomorrow

@VojtechStep
Copy link
Collaborator

Eh, sorry, it will have to wait one more day 😬

@fredrik-bakke
Copy link
Collaborator Author

No worries!

@fredrik-bakke
Copy link
Collaborator Author

FYI I won't have time to work on any additional review before monday next week at the earliest.

@VojtechStep VojtechStep enabled auto-merge (squash) August 13, 2025 23:17
@VojtechStep
Copy link
Collaborator

No additional changes necessary, queued for merging 🚀

@VojtechStep VojtechStep merged commit 982a607 into UniMath:master Aug 13, 2025
4 checks passed
@fredrik-bakke fredrik-bakke deleted the double-negation-logic branch August 14, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants