-
Notifications
You must be signed in to change notification settings - Fork 84
More logic #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More logic #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to go through the first half of files, hopefully to be continued some time next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the extra late review. I have some naming questions around density and propositional decidability I would like to have addressed before merging this development.
src/logic/propositionally-double-negation-eliminating-maps.lagda.md
Outdated
Show resolved
Hide resolved
…da.md Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
Co-authored-by: Vojtěch Štěpančík <vojtechstepancik@outlook.com>
@VojtechStep Thank you for the detailed review! I've tried to address all of your comments now. Let me know if further changes are required. |
I might not have the time today, but I should be able to look at all the updated PRs tomorrow |
Eh, sorry, it will have to wait one more day 😬 |
No worries! |
FYI I won't have time to work on any additional review before monday next week at the earliest. |
No additional changes necessary, queued for merging 🚀 |
Pulls logic additions from #1264.